Skip to content

Docs: Remove static dir flag from documentation#25291

Merged
ndelangen merged 2 commits into
nextfrom
docs_remove_static_assets_flag
Dec 21, 2023
Merged

Docs: Remove static dir flag from documentation#25291
ndelangen merged 2 commits into
nextfrom
docs_remove_static_assets_flag

Conversation

@jonniebigodes

Copy link
Copy Markdown
Contributor

Follows up on #25266

What I did

With this small pull request, the last remnants of the deprecated -s were removed from the documentation to align itself with the mentioned pull request.

@ndelangen let me know once you've merged your pull request so that I can merge this one, and we get this out. Thanks in advance.

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

@jonniebigodes jonniebigodes added documentation ci:docs Run the CI jobs for documentation checks only. labels Dec 20, 2023
@jonniebigodes jonniebigodes self-assigned this Dec 20, 2023
@jonniebigodes jonniebigodes changed the title Docs: Remove static dir flag remval Docs: Remove static dir flag removal Dec 20, 2023
@jonniebigodes jonniebigodes changed the title Docs: Remove static dir flag removal Docs: Remove static dir flag from documentation Dec 20, 2023
@ndelangen ndelangen merged commit 3f09b13 into next Dec 21, 2023
@ndelangen ndelangen deleted the docs_remove_static_assets_flag branch December 21, 2023 10:23
@github-actions github-actions Bot mentioned this pull request Dec 21, 2023
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci:docs Run the CI jobs for documentation checks only. documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants